Closed
Conversation
victorjulien
force-pushed
the
fw-arp/v2
branch
2 times, most recently
from
6d6e027 to
ae6871e
Compare
jufajardini
reviewed
Mar 24, 2026
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Maybe minor, but thinking about the coverage report, should we add tests that cover the ether and ports usage in a rule? (which should error out, from what I understood?)
catenacyber
reviewed
Mar 29, 2026
| @@ -0,0 +1 @@ | |||
| alert arp any any -> any any (sid:1;) | |||
Collaborator
There was a problem hiding this comment.
Should we test that alert ip does not alert on ARP packets ?
catenacyber
reviewed
Mar 29, 2026
| @@ -0,0 +1 @@ | |||
| alert ether any any -> any any (ether.hdr; content:"|08 06|"; offset:12; depth:2; sid:1;) | |||
Collaborator
There was a problem hiding this comment.
Is there a ticket for the ether.type keyword ?
jasonish
approved these changes
Mar 30, 2026
Member
Author
|
Merged in #2998, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/